legacy: Arduino preprocess subroutine refactorization #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
added
type: enhancement
cmaglie
force-pushed
the
cpp-preprocess-refactor
branch
from
f9cb4ba to
aa97f8d
Compare
There is no need to duplicate a function that basically does the same thing.
cmaglie
force-pushed
the
cpp-preprocess-refactor
branch
2 times, most recently
from
bdcdbb9 to
d5fa620
Compare
cmaglie
force-pushed
the
cpp-preprocess-refactor
branch
from
39042ea to
651b371
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2147 +/- ##
==========================================
- Coverage 62.45% 62.34% -0.12%
==========================================
Files 224 219 -5
Lines 19520 19392 -128
==========================================
- Hits 12191 12089 -102
+ Misses 6231 6205 -26
Partials 1098 1098
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
This was referenced May 25, 2023
|
Merged through other PRs. |
cmaglie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
It takes the sketch preprocessing out of the
legacypackage, hopefully making it more readable and straightforward.This is part of the bigger task #1486.
What is the current behavior?
No changes in behavior (hopefully :-))
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Other information
This PR (will be/has been) split into smaller PR: